Conversation
jbourassa
commented
Nov 29, 2022
Comment on lines
+62
to
+63
| class.define_method("consume_fuel=", method!(Config::set_consume_fuel, 1))?; | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
I'm not a huge fan of these setters, I think a builder-like API would be nice here too, and coherent with WasiCtxBuilder. But I decided to not shave this yak just yet.
Comment on lines
+5
to
+20
| def self.test_on_store_and_caller(desc, store = :store, &block) | ||
| context "on Store" do | ||
| it desc do | ||
| instance_exec(send(store), &block) | ||
| end | ||
| end | ||
|
|
||
| context "on Caller" do | ||
| it desc do | ||
| func = Func.new(send(store), FuncType.new([], [])) do |caller| | ||
| instance_exec(caller, &block) | ||
| end | ||
| func.call | ||
| end | ||
| end | ||
| end |
Collaborator
Author
There was a problem hiding this comment.
This is a little strange but allows writing the test once for both Store and Caller. I think it's worth it.
saulecabrera
approved these changes
Nov 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add fuel:
Fixes #25