Conversation
saulecabrera
approved these changes
Dec 9, 2022
Member
No objections on this. I actually prefer it this way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19
Add support for Wasm globals. Decisions worth validating:
GlobalTypes, I've chosen to define 2 constructors (GlobalType.const&GlobalType.var) instead of accepting mutability as an argument. It feels like a nicer UI, less error prone, and nothing precludes adding.newthat takes a symbol argument if we ever need that.GlobalType#content -> :i32). This naming feels odd to me, but didn't want to diverge without a clear reason.I'm looking into the memcheck failure but it does not look related to this PR, I can reproduce on main (edit: fix for memcheck in #75).