wasmtime-wizer: make rayon optional #12313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when compiling wasmtime-wizer to wasm32, rayon detects that and tries to use wasm-bindgen APIs the new rayon feature flag allows users to choose if snapshotting should be parallel or sequential
Gentle
force-pushed
the
feat-wizer_rayoff
branch
from
4f12c0d to
27473c1
Compare
github-actions
bot
added
the
wizer
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "wizer"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks! Can you add a check to CI as well, somewhere around here, that the crate builds without the rayon feature too?
alexcrichton
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when compiling wasmtime-wizer to wasm32, rayon detects that and tries to use wasm-bindgen APIs
the new rayon feature flag allows users to choose if snapshotting should be parallel or sequential
since it changes behavior, I made the feature default, but this could be changed if the crate should not have default features