fix cargo test wasmtime-wasi-http --no-default-features --features p3
#12380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvolosatovs
approved these changes
Jan 21, 2026
Member
|
We do test the |
Contributor
Author
|
I just realized this PR doesn't do what I said it does anyway. The CI change only enables |
dicej
force-pushed
the
fix-wasmtime-wasi-http-p3
branch
from
6d4caa6 to
186cdbc
Compare
dicej
changed the title
wasmtime-wasi-http p3 tests and run them in CIcargo test wasmtime-wasi-http --no-default-features --features p3
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
crates/wasi-http/Cargo.toml
Outdated
| webpki-roots = { workspace = true, optional = true } | ||
|
|
||
| [dev-dependencies] | ||
| wasmtime-wasi-http = { workspace = true, features = ['default-send-request'] } |
Member
There was a problem hiding this comment.
This is where the error comes from, and you can fix it by replacing workspace = true with path = "." (helps resolve the circular dep cargo-wise)
Recently, the above stopped building. This fixes the damage and adds CI coverage.
dicej
force-pushed
the
fix-wasmtime-wasi-http-p3
branch
from
186cdbc to
9ccd77e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, the above stopped building. This fixes the damage and adds CI coverage.