Handle OOM in wasmtime_environ::types::WasmFuncType's serde support#12672
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom Feb 25, 2026
Merged
Conversation
crates/environ/src/types.rs
Outdated
| } | ||
| } | ||
|
|
||
| impl<'de> serde::Deserialize<'de> for WasmFuncType { |
Member
There was a problem hiding this comment.
Since this is pretty gnarly, could #[serde(deserialize_with)] be used instead on the params_results field? That would delegate to a custom function that would deserialize into a fallible Vec which would then fallibly be converted to Box<[T]>.
Member
Author
There was a problem hiding this comment.
Oh nice, I didn't know that was there
fitzgen
force-pushed
the
handle-oom-in-wasm-func-type-serde-support
branch
from
064e1eb to
adf5070
Compare
alexcrichton
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #12670