Handle OOM in Linker::instantiate_pre#12683
Merged
fitzgen merged 1 commit intobytecodealliance:mainfrom Feb 27, 2026
Merged
Conversation
alexcrichton
approved these changes
Feb 26, 2026
| InstancePreDefinitions { | ||
| #[expect(dead_code, reason = "only here to keep the original value alive")] | ||
| defs: Arc<[Definition]>, | ||
| defs: Arc<collections::Vec<Definition>>, |
Member
There was a problem hiding this comment.
As we go further and further down this road, were you thinking of replacing these with KVec<T> at some point? Or were you hoping someone else would pick that up?
Member
Author
There was a problem hiding this comment.
I'm still not sold on KVec<T> which is my reason for delaying...
Leaning back towards TryVec<T> again...
I don't know
fitzgen
force-pushed
the
handle-oom-in-linker-instantiate-pre
branch
from
a65481a to
709ab40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #12682
Part of #12069