cm-async: Fix cancelling a completed host task#12797
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Mar 18, 2026
Merged
cm-async: Fix cancelling a completed host task#12797alexcrichton merged 1 commit intobytecodealliance:mainfrom
alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
Incorrect behavior on Wasmtime's part led to erroneously raising a trap in the guest about the terminal status of a task being delivered already. This commit refactors some internals to ensure that cancelling a completed host task is not a failure, it instead just returns that the host task is indeed completed.
alexcrichton
requested review from
cfallin and
dicej
and removed request for
a team and
cfallin
github-actions
bot
added
the
wasmtime:api
dicej
approved these changes
Mar 18, 2026
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Mar 18, 2026
Incorrect behavior on Wasmtime's part led to erroneously raising a trap in the guest about the terminal status of a task being delivered already. This commit refactors some internals to ensure that cancelling a completed host task is not a failure, it instead just returns that the host task is indeed completed.
alexcrichton
added a commit
that referenced
this pull request
Mar 19, 2026
Incorrect behavior on Wasmtime's part led to erroneously raising a trap in the guest about the terminal status of a task being delivered already. This commit refactors some internals to ensure that cancelling a completed host task is not a failure, it instead just returns that the host task is indeed completed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorrect behavior on Wasmtime's part led to erroneously raising a trap in the guest about the terminal status of a task being delivered already. This commit refactors some internals to ensure that cancelling a completed host task is not a failure, it instead just returns that the host task is indeed completed.