gc_ops: Address assertion failure in the types fixup()#12900
Merged
fitzgen merged 1 commit intobytecodealliance:mainfrom Mar 31, 2026
Merged
gc_ops: Address assertion failure in the types fixup()#12900fitzgen merged 1 commit intobytecodealliance:mainfrom
fixup()#12900fitzgen merged 1 commit intobytecodealliance:mainfrom
Conversation
…ppears in multiple rec groups' member sets.
alexcrichton
requested review from
fitzgen
and removed request for
alexcrichton
github-actions
bot
added
the
fuzzing
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "fuzzing"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Types::fixupto handle types appearing in multiple rec groups opened in #12892.Libfuzzer mutations can place the same
TypeIdin more than one rec group.is_well_formedasserted against this but fixup never corrected it, causing a failure. Added a dedup pass that keeps each type in only the first group. Also simplified the orphan logic since we no longer need to distinguish corruption orphans from trimmed-group orphans. Added log info to theis_well_formedfunction to see the reason of failure.cc @fitzgen
Closes #12892