Remove incorrect noop in unix stack pool management#13069
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Apr 13, 2026
Merged
Remove incorrect noop in unix stack pool management#13069alexcrichton merged 1 commit intobytecodealliance:mainfrom
alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
This commit removes a call to `commit_pages` in the `unix_stack_pool.rs` file. This function is a noop on unix and the parameters passed in for this call were also incorrect if it actually needed to do something anyway. This is otherwise just distracting, so remove it.
fitzgen
approved these changes
Apr 13, 2026
github-actions
Bot
added
the
wasmtime:api
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes a call to
commit_pagesin theunix_stack_pool.rsfile. This function is a noop on unix and the parameters passed in for this call were also incorrect if it actually needed to do something anyway. This is otherwise just distracting, so remove it.