Skip to content

Add skeleton copying collector#13093

Merged
fitzgen merged 1 commit intobytecodealliance:mainfrom
fitzgen:skeleton-of-copying-collector
Apr 14, 2026
Merged

Add skeleton copying collector#13093
fitzgen merged 1 commit intobytecodealliance:mainfrom
fitzgen:skeleton-of-copying-collector

Conversation

@fitzgen
Copy link
Copy Markdown
Member

@fitzgen fitzgen commented Apr 14, 2026

This commit adds the skeleton of a new copying collector, guarded behind a new "gc-copying" cargo feature. It compiles and implements the various Gc* traits to interface with the runtime and compiler, but is not yet actually functional.

The copying collector is intentionally excluded from the fuzzing config generator, as it isn't ready to be fuzzed yet.

cc #10329

This commit adds the skeleton of a new copying collector, guarded behind a new
"gc-copying" cargo feature. It compiles and implements the various `Gc*` traits
to interface with the runtime and compiler, but is not yet actually functional.

The copying collector is intentionally excluded from the fuzzing config
generator, as it isn't ready to be fuzzed yet.
@fitzgen fitzgen requested review from a team as code owners April 14, 2026 16:51
@fitzgen fitzgen requested review from alexcrichton and uweigand and removed request for a team April 14, 2026 16:51
@github-actions github-actions Bot added wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:c-api Issues pertaining to the C API. wasmtime:config Issues related to the configuration of Wasmtime wasmtime:ref-types Issues related to reference types and GC in Wasmtime winch Winch issues or pull requests labels Apr 14, 2026
@github-actions
Copy link
Copy Markdown

Subscribe to Label Action

cc @fitzgen, @saulecabrera

Details This issue or pull request has been labeled: "wasmtime:api", "wasmtime:c-api", "wasmtime:config", "wasmtime:ref-types", "winch"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: wasmtime:ref-types
  • saulecabrera: winch

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@alexcrichton
Copy link
Copy Markdown
Member

The copying collector is intentionally excluded from the fuzzing config generator, as it isn't ready to be fuzzed yet.

Would it makes sense to leave comments as FIXMEs pointing to a tracking issue in a few locations (like fuzzing, the default set of features, etc) where this should go once it's ready?

@github-actions
Copy link
Copy Markdown

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Details

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    Details

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


Details

To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

@fitzgen
Copy link
Copy Markdown
Member Author

fitzgen commented Apr 14, 2026

Would it makes sense to leave comments as FIXMEs pointing to a tracking issue in a few locations (like fuzzing, the default set of features, etc) where this should go once it's ready?

I have WIP fuzzing integration in some follow up work already so I don't think we need FIXMEs in the code at this time? But making a checklist somewhere of what we want done before enabling GC by default would be good to have. I'll whip that up in a little bit.

@fitzgen fitzgen added this pull request to the merge queue Apr 14, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 14, 2026
@fitzgen fitzgen added this pull request to the merge queue Apr 14, 2026
Merged via the queue into bytecodealliance:main with commit bc82e7a Apr 14, 2026
52 checks passed
@fitzgen fitzgen deleted the skeleton-of-copying-collector branch April 14, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:c-api Issues pertaining to the C API. wasmtime:config Issues related to the configuration of Wasmtime wasmtime:ref-types Issues related to reference types and GC in Wasmtime winch Winch issues or pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants