cm-async: Fix leaking thread data into a store on cancel#13098
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Apr 14, 2026
Merged
cm-async: Fix leaking thread data into a store on cancel#13098alexcrichton merged 1 commit intobytecodealliance:mainfrom
alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
This commit fixes an issue where when a subtask is cancelled while it's in the `STARTING` state this would leak data within the store. The fix here is to call a dedicated cleanup function which handles all the fields of a thread appropriately.
alexcrichton
requested review from
cfallin and
dicej
and removed request for
a team and
cfallin
dicej
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where when a subtask is cancelled while it's in the
STARTINGstate this would leak data within the store. The fix here is to call a dedicated cleanup function which handles all the fields of a thread appropriately.