Fix some comparison-related clif optimization rules#13099
Merged
fitzgen merged 2 commits intobytecodealliance:mainfrom Apr 14, 2026
Merged
Fix some comparison-related clif optimization rules#13099fitzgen merged 2 commits intobytecodealliance:mainfrom
fitzgen merged 2 commits intobytecodealliance:mainfrom
Conversation
The fix in bytecodealliance#13063 failed to take into account some extra rules in `bitops.isle` which now works for vector types and didn't correctly use the `cmp_true` helper to create a "true" value for the destination type.
github-actions
Bot
added
cranelift
fitzgen
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix in #13063 failed to take into account some extra rules in
bitops.islewhich now works for vector types and didn't correctly use thecmp_truehelper to create a "true" value for the destination type.