Clean up helper task in AsyncReadStream faster#13105
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Apr 14, 2026
Merged
Clean up helper task in AsyncReadStream faster#13105alexcrichton merged 1 commit intobytecodealliance:mainfrom
AsyncReadStream faster#13105alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
The previous implementation would hit EOF on the input object, then hit EOF again, and then block on sending a value over the channel. There's no need for the task to stick around and infinitely generate EOF messages, however, so exit the task as soon as the first EOF is hit and a message is sent.
dicej
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation would hit EOF on the input object, then hit EOF again, and then block on sending a value over the channel. There's no need for the task to stick around and infinitely generate EOF messages, however, so exit the task as soon as the first EOF is hit and a message is sent.
This was originally submitted as #13061 but then closed without any further communication. Nevertheless this seems like a prudent issue to fix.