Don't create a pool of GC heaps if it's disabled#13139
Merged
fitzgen merged 1 commit intobytecodealliance:mainfrom Apr 20, 2026
Merged
Don't create a pool of GC heaps if it's disabled#13139fitzgen merged 1 commit intobytecodealliance:mainfrom
fitzgen merged 1 commit intobytecodealliance:mainfrom
Conversation
A fuzz test case is failing right now on `main` where the validation in `Config` only checks tunables if a collector is enabled, but the GC pool creation unconditionally check the tunables. This also felt a bit odd creating a GC heap pool when the GC itself is disabled, so the code is refactored to avoid creating a GC heap pool at all when a collector is disabled.
github-actions
bot
added
the
wasmtime:api
fitzgen
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fuzz test case is failing right now on
mainwhere the validation inConfigonly checks tunables if a collector is enabled, but the GC pool creation unconditionally check the tunables. This also felt a bit odd creating a GC heap pool when the GC itself is disabled, so the code is refactored to avoid creating a GC heap pool at all when a collector is disabled.