Fill out MAY_REQUIRE_REALLOC for more types#13158
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Apr 21, 2026
Merged
Fill out MAY_REQUIRE_REALLOC for more types#13158alexcrichton merged 1 commit intobytecodealliance:mainfrom
MAY_REQUIRE_REALLOC for more types#13158alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
This is an relatively impactful optimization to the performance of futures/streams when transferring data from the host to the guest, so fill this out for more types get the optimization to fire more. This was found during some improvement of wasi-libc where some code paths weren't getting hit, but they should,, and this is required to have that work out.
github-actions
Bot
added
the
wasmtime:api
dicej
approved these changes
Apr 21, 2026
alexcrichton
added a commit
to alexcrichton/wasi-libc
that referenced
this pull request
Apr 21, 2026
Set the flags that an accept is in-progress regardless of whether it completes or not, resolving an assertion failure. This is not currently possible to test with Wasmtime, but with bytecodealliance/wasmtime#13158 and the test included here the assertion is hit reliably.
alexcrichton
added a commit
to WebAssembly/wasi-libc
that referenced
this pull request
Apr 21, 2026
Set the flags that an accept is in-progress regardless of whether it completes or not, resolving an assertion failure. This is not currently possible to test with Wasmtime, but with bytecodealliance/wasmtime#13158 and the test included here the assertion is hit reliably.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an relatively impactful optimization to the performance of futures/streams when transferring data from the host to the guest, so fill this out for more types get the optimization to fire more. This was found during some improvement of wasi-libc where some code paths weren't getting hit, but they should,, and this is required to have that work out.