Re-land Always use mmap in cranelift-jit #13186
Merged
fitzgen merged 1 commit intobytecodealliance:mainfrom Apr 24, 2026
Merged
Re-land Always use mmap in cranelift-jit #13186fitzgen merged 1 commit intobytecodealliance:mainfrom
fitzgen merged 1 commit intobytecodealliance:mainfrom
Conversation
alexcrichton
requested review from
fitzgen and
uweigand
and removed request for
a team
* Always use mmap in cranelift-jit This was previously not done with the theory that using the regular heap allocator could be faster. We now have an arena memory provider and using mmap is necessary anyway when SELinux is enabled. I don't think the benefits outweight the code complexity cost. * Use memmap2 on Windows too in cranelift-jit
fitzgen
approved these changes
Apr 24, 2026
kendricklawton
pushed a commit
to kendricklawton/wasmtime
that referenced
this pull request
Apr 24, 2026
* wizer: move the special regex-test crate to be in test-prrograms this eliminates the test calling out to `cargo build` directly, instead it uses a dep on `test-programs-artifacts` * wizer regex test also works as a component * link FIXME to bytecodealliance#13186 * inline wit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub merge queues ate #13180 yesterday. Re-land it.