[Cranelift] fix e-graph rewrite depth limit#13205
Merged
fitzgen merged 1 commit intobytecodealliance:mainfrom Apr 27, 2026
Merged
[Cranelift] fix e-graph rewrite depth limit#13205fitzgen merged 1 commit intobytecodealliance:mainfrom
fitzgen merged 1 commit intobytecodealliance:mainfrom
Conversation
myunbin
force-pushed
the
fix_e-graph_rewrite_depth_limit
branch
from
0d300c1 to
8ae47ed
Compare
github-actions
Bot
added
the
cranelift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an off-by-one in the e-graph rewrite depth limit.
REWRITE_LIMITis set to 5. Current check usesrewrite_depth > REWRITE_LIMITbefore incrementing the depth. Sincerewrite_depthstarts at 0, this allows rewrites to run at effective depth 6.If the intended maximum rewrite depth is 5, this changes the check to
rewrite_depth >= REWRITE_LIMIT.Noticed while investigating #13204.