Refactor how inlining is configured in Wasmtime#13250
Refactor how inlining is configured in Wasmtime#13250alexcrichton wants to merge 2 commits intobytecodealliance:mainfrom
Conversation
Fold the `inlining` boolean and the `inlining_intra_module` options into a single `Inlining` enum option. This option encompasses both and has an additional mode which is "only intrinsics" where inter-module and intra-module calls are never inlined, but intrinsics for Wasmtime are allowed to be inlined. This is inspired from discussion on bytecodealliance#13214 and after some performance work and/or confirmations the expectation is to turn the default inlining mode to `Inlining::Intrinsics`.
|
A few points of note here:
|
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "fuzzing", "wasmtime:api", "wasmtime:config"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Label Messager: wasmtime:configIt looks like you are changing Wasmtime's configuration options. Make sure to
DetailsTo modify this label's message, edit the To add new label messages or remove existing label messages, edit the |
Fold the
inliningboolean and theinlining_intra_moduleoptions into a singleInliningenum option. This option encompasses both and has an additional mode which is "only intrinsics" where inter-module and intra-module calls are never inlined, but intrinsics for Wasmtime are allowed to be inlined. This is inspired from discussion on #13214 and after some performance work and/or confirmations the expectation is to turn the default inlining mode toInlining::Intrinsics.