Skip to content

Refactor how inlining is configured in Wasmtime#13250

Open
alexcrichton wants to merge 2 commits intobytecodealliance:mainfrom
alexcrichton:refactor-inlining
Open

Refactor how inlining is configured in Wasmtime#13250
alexcrichton wants to merge 2 commits intobytecodealliance:mainfrom
alexcrichton:refactor-inlining

Conversation

@alexcrichton
Copy link
Copy Markdown
Member

Fold the inlining boolean and the inlining_intra_module options into a single Inlining enum option. This option encompasses both and has an additional mode which is "only intrinsics" where inter-module and intra-module calls are never inlined, but intrinsics for Wasmtime are allowed to be inlined. This is inspired from discussion on #13214 and after some performance work and/or confirmations the expectation is to turn the default inlining mode to Inlining::Intrinsics.

Fold the `inlining` boolean and the `inlining_intra_module` options into
a single `Inlining` enum option. This option encompasses both and has an
additional mode which is "only intrinsics" where inter-module and
intra-module calls are never inlined, but intrinsics for Wasmtime are
allowed to be inlined. This is inspired from discussion on bytecodealliance#13214 and
after some performance work and/or confirmations the expectation is to
turn the default inlining mode to `Inlining::Intrinsics`.
@alexcrichton alexcrichton requested review from a team as code owners May 1, 2026 20:46
@alexcrichton alexcrichton requested review from fitzgen and removed request for a team May 1, 2026 20:46
@alexcrichton
Copy link
Copy Markdown
Member Author

A few points of note here:

  • This PR is not seeking to change the default of "inlining is off"
  • This PR changes the meaning of -Cinlining to "inline everything you can" as opposed to the previous WhenUsingGc option.

@github-actions github-actions Bot added fuzzing Issues related to our fuzzing infrastructure wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime labels May 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

Subscribe to Label Action

cc @fitzgen

Details This issue or pull request has been labeled: "fuzzing", "wasmtime:api", "wasmtime:config"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Details

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    Details

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


Details

To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fuzzing Issues related to our fuzzing infrastructure wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant