Skip to content

Add a test to exercise GC and MIRI#13357

Open
fitzgen wants to merge 1 commit into
bytecodealliance:mainfrom
fitzgen:add-test-to-exercise-gc-and-miri
Open

Add a test to exercise GC and MIRI#13357
fitzgen wants to merge 1 commit into
bytecodealliance:mainfrom
fitzgen:add-test-to-exercise-gc-and-miri

Conversation

@fitzgen
Copy link
Copy Markdown
Member

@fitzgen fitzgen commented May 13, 2026

This test doesn't actually compile or run any Wasm functions, which means it can
easily run under MIRI, but does exercise the very basics of garbage
collection (notably, GC roots and their updating, which has historically been
problematic under MIRI).

Depends on #13356

@fitzgen fitzgen requested a review from a team as a code owner May 13, 2026 21:04
@fitzgen fitzgen requested review from pchickey and removed request for a team May 13, 2026 21:04
@fitzgen fitzgen force-pushed the add-test-to-exercise-gc-and-miri branch from 5e10c5b to 03dd1a4 Compare May 13, 2026 21:07
@github-actions github-actions Bot added the wasmtime:api Related to the API of the `wasmtime` crate itself label May 13, 2026
Copy link
Copy Markdown
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, well I don't think either of us expected this to turn up a GC bug but here we are!

@fitzgen fitzgen force-pushed the add-test-to-exercise-gc-and-miri branch from 03dd1a4 to 9f0ca02 Compare May 14, 2026 00:08
@fitzgen
Copy link
Copy Markdown
Member Author

fitzgen commented May 14, 2026

Huh, well I don't think either of us expected this to turn up a GC bug but here we are!

The gc_zeal failure in CI is fixed by #13330, will rebase after that merges.

This test doesn't actually compile or run any Wasm functions, which means it can
easily run under MIRI, but does exercise the very basics of garbage
collection (notably, GC roots and their updating, which has historically been
problematic under MIRI).
@fitzgen fitzgen force-pushed the add-test-to-exercise-gc-and-miri branch from 9f0ca02 to 357d7c3 Compare May 14, 2026 17:23
@fitzgen fitzgen enabled auto-merge May 14, 2026 17:24
@fitzgen fitzgen added this pull request to the merge queue May 14, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wasmtime:api Related to the API of the `wasmtime` crate itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants