wasmtime: generalize InstanceExportLookup into ExportLookup#13500
Merged
Conversation
pchickey
force-pushed
the
pch/export_lookup
branch
from
dccc9db to
2c11692
Compare
because changing from &str to impl ExportLookup in argument to Component::get_export created ambiguity
alexcrichton
approved these changes
May 28, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
Last merge queue failure was because a mac ci runner hung |
yagehu
pushed a commit
to yagehu/wasmtime-x
that referenced
this pull request
Jun 1, 2026
…alliance#13500) * wasmtime::component: rename InstanceExportLookup to ExportLookup * Component::get_ functions can use ExportLookup as well now * wasmtime wit bindgen, component macro: add type annotation because changing from &str to impl ExportLookup in argument to Component::get_export created ambiguity * fix docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
wasmtime::component::Instancestruct had getter methods that acceptedimpl InstanceExportLookup, a pseudo-sealed trait (via#[doc(hidden)]) with impls for &str, String, or ComponentExportIndex.Conversely, the
wasmtime::component::Componentstruct hadget_exportandget_export_indexmethods which took argumentsinstance: Option<&ComponentExportIndex>andname: &str.This PR renames the trait to
ExportLookup, with the exact same impls, and modifies theComponent::get_export[_index]methods to takeimpl ExportLookupinstead of&strarguments.This is motivated by a follow-up PR that will add
wit_parser::ItemNameas another type that impls ExportIndex.