Skip to content

wasmtime: Use fine-grained alias regions for memory, globals, tables, vmctx, and GC heap#13525

Merged
fitzgen merged 3 commits into
bytecodealliance:mainfrom
fitzgen:fine-grained-memory-global-table-alias-regions
Jun 1, 2026
Merged

wasmtime: Use fine-grained alias regions for memory, globals, tables, vmctx, and GC heap#13525
fitzgen merged 3 commits into
bytecodealliance:mainfrom
fitzgen:fine-grained-memory-global-table-alias-regions

Conversation

@fitzgen
Copy link
Copy Markdown
Member

@fitzgen fitzgen commented Jun 1, 2026

Defines an AliasRegionKey that gets turned into a Cranelift ir::AliasRegionData and yields a different region per defined memory/global/table vs GC heap vs vmctx structures, etc...

Relatively small diff in reality, only a few hundred lines, but the disas test expectations all got updated.

@fitzgen fitzgen requested review from a team as code owners June 1, 2026 18:04
@fitzgen fitzgen requested review from cfallin and removed request for a team June 1, 2026 18:04
Copy link
Copy Markdown
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One question about new tests but otherwise LGTM.

Comment thread crates/cranelift/src/translate/code_translator.rs
@fitzgen fitzgen force-pushed the fine-grained-memory-global-table-alias-regions branch from 3f62857 to ba8a951 Compare June 1, 2026 20:57
@fitzgen fitzgen enabled auto-merge June 1, 2026 20:57
@fitzgen fitzgen added this pull request to the merge queue Jun 1, 2026
Merged via the queue into bytecodealliance:main with commit b6efdac Jun 1, 2026
51 checks passed
@fitzgen fitzgen deleted the fine-grained-memory-global-table-alias-regions branch June 1, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants