Auto-generate shims for old wasi_unstable module#845
Closed
alexcrichton wants to merge 2 commits intobytecodealliance:masterfrom
Closed
Auto-generate shims for old wasi_unstable module#845alexcrichton wants to merge 2 commits intobytecodealliance:masterfrom
wasi_unstable module#845alexcrichton wants to merge 2 commits intobytecodealliance:masterfrom
Conversation
This commit is effectively just doing what bytecodealliance#707 already did, but applying it to the `snapshot_0` module as well. The end result is the same, where we cut down on all the boilerplate in `snapshot_0` and bring it in line with the main `wasi_snapshot_preview1` implementation. The goal here is to make it easier to change the two in tandem since they're both doing the same thing.
alexcrichton
force-pushed
the
modern-unstable
branch
from
96ab48b to
d421bec
Compare
Member
|
I left more review in the subsequent PR, but none touching this code, so as far as I'm concerned, we're good to go here. |
Member
Author
|
Bah I misinterpreted your comments on #846 as comments here, so I accidentally merged that first. Will update this as necessary. |
Member
Author
|
Er looks like that picked up everything, so I'm going to close this because I accidentally merged it with the other one. Will pay more attention next time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is effectively just doing what #707 already did, but
applying it to the
snapshot_0module as well. The end result is thesame, where we cut down on all the boilerplate in
snapshot_0and bringit in line with the main
wasi_snapshot_preview1implementation. Thegoal here is to make it easier to change the two in tandem since they're
both doing the same thing.