c#: Fix same name issue in resources

[jsturtevant]

possible fix for #1232

I am not a huge fan of this but not sure if there is another way

@yowl @silesmo @pavelsavara thoughts?

[pavelsavara]

Perhaps there could be opt-in mapping per type. --map-resource-name=XYZ:XYZResource or something like that.
Or even for that specific method. --map-function-name=foo.foo:foo.fooFactory

[pavelsavara]

Making C# look differently than wit is not great. Let's keep the problem as localized as possible.

[jsturtevant]

Perhaps there could be opt-in mapping per type. --map-resource-name=XYZ:XYZResource or something like that.
Or even for that specific method. --map-function-name=foo.foo:foo.fooFactory
Making C# look differently than wit is not great. Let's keep the problem as localized as possible.

💯. thanks for the suggestion, I'll see if I can get it working

[pavelsavara]

If we want something that magically always works, we could have foo._foo or foo.foo1 when we detect class and method name match.

[silesmo]

I understand the reasoning for allowing to re-map the name of a type. But that will also add edge cases where you would need to manually remap something if they clash? I would expect the tooling to handle this automatically to not introduce additional hurdles for new users to adopt C# with wasi. @pavelsavara @jsturtevant

[pavelsavara]

I guess other languages also have naming clashes, for example with keywords or with method names that start with numbers. having same rules would help.

That said naming something foo.foo is bad idea and that's why C# has the rule in place. Maybe we could also propagate that rule to wit spec ?

[silesmo]

Keywords are generally handled by escaping the keyword. So it wouldn't directly map to this problem.

Yea I wouldn't mind trying to push it to the wit spec if we can get others to agree.

[jsturtevant]

dropping a few more notes here:

• c generator does have a some renaming but not exactly the same as we are discussing here

  • wit-bindgen/crates/c/src/lib.rs

    Lines 87 to 92 in 5e7d46c

    	#[cfg_attr(feature = "clap", arg(long, name = "K=V", value_parser = parse_rename))]
    	pub rename: Vec<(String, String)>,
    	/// Rename the world in the generated source code and file names.
    	#[cfg_attr(feature = "clap", arg(long))]
    	pub rename_world: Option<String>,

• wit has some limited renaming of via use but also not of use here
  • https://github.com/WebAssembly/component-model/blob/main/design/mvp/WIT.md#top-level-use

[jsturtevant]

something like foo._foo might be relatively unobtrusive.

I've also raised the issue in the component model WebAssembly/component-model#478

[jsturtevant]

proposed change to the spec: WebAssembly/component-model#494

[jsturtevant]

this is now part of the spec: WebAssembly/component-model#494 with a change going into the tooling: bytecodealliance/wasm-tools#2138