drop subtasks in cancel-import/runner.c test#1345
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Jul 30, 2025
Merged
drop subtasks in cancel-import/runner.c test#1345alexcrichton merged 1 commit intobytecodealliance:mainfrom
cancel-import/runner.c test#1345alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
This was causing a panic in Wasmtime when disposing of the guest task parent of those subtasks. Wasmtime shouldn't be panicking no matter what the guest does, so I'll need to fix that, but meanwhile we might as well have good handle hygene in our tests. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
alexcrichton
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing a panic in Wasmtime when disposing of the guest task parent of those subtasks. Wasmtime shouldn't be panicking no matter what the guest does, so I'll need to fix that, but meanwhile we might as well have good handle hygene in our tests.