Implement the component-model lexing rules for identifiers.#382
Merged
alexcrichton merged 4 commits intobytecodealliance:mainfrom Oct 19, 2022
Merged
Conversation
Member
|
Given the current CI errors, I think one of two things needs to happen:
I'd sort of prefer to avoid having to generate separate bindings for |
Member
Author
|
I think we should do something in the upstream component model definition. I filed WebAssembly/component-model#118 to track this. |
Member
|
Ok sounds good to me, want to update the test to not exercise this casing collision to merge? |
The [component-model grammer] for kebab-case identifiers now looks
like this:
```
name ::= <word>
| <name>-<word>
word ::= [a-z][0-9a-z]*
| [A-Z][0-9A-Z]*
```
Implement the rules. This continues to use XID rules for the initial
lexing, as that corresponds to what users might accidentally use, so
that we can issue appropriate errors in those cases. The precise
grammer is validated in a separate step.
[component-model grammer]: https://github.com/WebAssembly/component-model/blob/main/design/mvp/Explainer.md#instance-definitions
sunfishcode
force-pushed
the
sunfishcode/kebab-case
branch
from
5f5423c to
b95cf82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The component-model grammer for kebab-case identifiers now looks like this:
Implement the rules. This continues to use XID rules for the initial lexing, as that corresponds to what users might accidentally use, so that we can issue appropriate errors in those cases. The precise grammer is validated in a separate step.