Strip component-type* custom sections during componentization#397
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Oct 26, 2022
Merged
Conversation
This commit leverages a new convenience API in `wasmparser` to strip the `component-type*` custom sections emitted by `wit-bindgen` guests during the componentization process for a core wasm module. These custom sections don't have any place in the core wasm module except as part of the build process and will end up just duplicating bits and pieces of the component itself, so there's no need for them to stick around once a component has been created.
peterhuene
approved these changes
Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit leverages a new convenience API in
wasmparserto strip thecomponent-type*custom sections emitted bywit-bindgenguests during the componentization process for a core wasm module. These custom sections don't have any place in the core wasm module except as part of the build process and will end up just duplicating bits and pieces of the component itself, so there's no need for them to stick around once a component has been created.