Allow adapters to import multiple interfaces#398
Merged
pchickey merged 1 commit intobytecodealliance:mainfrom Oct 26, 2022
Merged
Allow adapters to import multiple interfaces#398pchickey merged 1 commit intobytecodealliance:mainfrom
pchickey merged 1 commit intobytecodealliance:mainfrom
Conversation
This commit lifts the restriction that an adapter module as part of `wit-component` can only import a single interface. That restriction was a temporary artifact of the initial implementation due to the fact that at the time there was no convenient way to communicate about multiple imported interfaces. With the `ComponentInterfaces` encoding of a "world" now, though, the `wit-component` CLI is updated to require that the incoming adapter module has a `component-type*` custom section describing the world that it's importing.
alexcrichton
force-pushed
the
adapt-multiple-interfaces
branch
from
acb54f3 to
6aa45ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit lifts the restriction that an adapter module as part of
wit-componentcan only import a single interface. That restriction was a temporary artifact of the initial implementation due to the fact that at the time there was no convenient way to communicate about multiple imported interfaces. With theComponentInterfacesencoding of a "world" now, though, thewit-componentCLI is updated to require that the incoming adapter module has acomponent-type*custom section describing the world that it's importing.