update the Java guest generator for world-based generation#405
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Oct 28, 2022
Merged
update the Java guest generator for world-based generation#405alexcrichton merged 1 commit intobytecodealliance:mainfrom
alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
We now generate a top-level class for the world, which contains any tuple, result, and cleanup types, as well as the return area (if needed) and the custom section directive for the component type. Each imported or exported interface also gets its own top level file in the same package as the world class. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dicej
force-pushed
the
java-world-generator
branch
from
b439ad8 to
6b66c36
Compare
alexcrichton
approved these changes
Oct 28, 2022
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Looks great to me, thanks again for helping out with this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now generate a top-level class for the world, which contains any tuple, result, and cleanup types, as well as the return area (if needed) and the custom section directive for the component type. Each imported or exported interface also gets its own top level file in the same package as the world class.
Signed-off-by: Joel Dice joel.dice@fermyon.com