Emit component name in core Wasm file names#408
Merged
guybedford merged 4 commits intobytecodealliance:mainfrom Oct 31, 2022
Merged
Emit component name in core Wasm file names#408guybedford merged 4 commits intobytecodealliance:mainfrom
guybedford merged 4 commits intobytecodealliance:mainfrom
Conversation
Member
|
Could this perhaps be threaded through to the generators in some form of a structure describing the names? That should avoid having three locations that all need to be kept in sync as the naming scheme gets fancier. |
added 3 commits
October 31, 2022 10:29
Contributor
Author
|
Good point, I've updated the PR to use a |
alexcrichton
approved these changes
Oct 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the generator to rather than outputting
module{n}.wasmfor the core Wasm files, to instead use the naming scheme{name}.core{n}.wasmand also in addition whenn == 0to emit then.This way applications with a single Wasm file get an unnumbered Wasm, and the loaded Wasm file has a component-specific name eg in the network tab etc.
In addition this also fixes a one-liner regression in the Node.js compat output which wasn't using
compileStreaming, and corrects the unhandled rejection handler attachment in the singular case for the JS generator.