gen-host-js: base64 option#411
Merged
guybedford merged 2 commits intobytecodealliance:mainfrom Nov 3, 2022
Merged
Conversation
alexcrichton
approved these changes
Nov 3, 2022
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Can you add some tests for this as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
--base64flag to the JS host generator for inlining the Wasm.This is almost always a terrible idea and so the option has been hidden from the options display.The option has been left in the help without warnings, so users can use it as appropriate.It can be useful in certain contexts though, such as for es-module-lexer where the binary size is very carefully managed and a latency delay for a separate fetch during browser intialization wouldn't be acceptable. It doesn't add much code complexity overhead at all though thankfully.