host-gen-js: Output optimization#416
Closed
guybedford wants to merge 7 commits intobytecodealliance:mainfrom
Closed
host-gen-js: Output optimization#416guybedford wants to merge 7 commits intobytecodealliance:mainfrom
guybedford wants to merge 7 commits intobytecodealliance:mainfrom
Conversation
Member
|
This looks reasonable, but the |
Contributor
Author
|
Ah, ok I can't come up with a better alternative, will close this then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based to #415, which is in turn based to #414, so should land after those.
Updates the output to be more friendly to minifiers resulting in a smaller total JS file size - arrow functions are used for intrinsics, and the
dataView(memory)pattern is replaced with a dedicateddataView{n}binding per memory, which should be able to be optimized out if not used for a particular memory.