Fix some test-related issues#419
Merged
alexcrichton merged 3 commits intobytecodealliance:mainfrom Nov 8, 2022
Merged
Conversation
Otherwise the build process thinks this is always missing so tests are always slowly rebuilt.
This requires the `clap` feature to be enabled now which works with `cargo test --workspace` but isn't working with individual crate testing.
Different versions of `wasi-libc` will produce differently sized binaries, so only test the generated JS which this repo controls.
guybedford
approved these changes
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More details in the commits below but this is required for me to locally get
cargo test -p wit-bindgen-gen-host-js --test runtimeworking again.