gen-host-js: make ComponentError string payload non-enumerable#426
Merged
guybedford merged 2 commits intobytecodealliance:mainfrom Nov 10, 2022
Merged
Conversation
7b96282 to
5530d24
Compare
alexcrichton
approved these changes
Nov 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the
payloadproperty non-enumerable when it is a string, while keeping it enumerable when it is not a string. This way it doesn't show up twice in Node.js error stacks. Browser error logging remains identical both for thrown and logged error strings.In addition, when the payload is not a string, we add an additional note -
(see error.payload)to the error message so that the message will look like:for object errors, while remaining enumerable so that error logging environments that do log the enumerable
payloadproperty for non-strings will be able to log the object as well.For example, here's wit-bindgen error strings before and after in Node.js.
Before:
After:
Node.js will display the object payload as enumerable otherwise for non strings.