Skip to content

Issue #103 Do not use Multi-Modules#104

Merged
bytefish merged 5 commits intomasterfrom
jdk18
Oct 9, 2020
Merged

Issue #103 Do not use Multi-Modules#104
bytefish merged 5 commits intomasterfrom
jdk18

Conversation

@bytefish
Copy link
Copy Markdown
Owner

@bytefish bytefish commented Oct 9, 2020

I have merged all modules into a single jar, so we don't build multiple-modules anymore. In Issue #103 it became clear, that targetting multiple JDKs using a classifier is apparently not possible. The project doesn't use any specific Java11 Features, so we should be safe to build for 1.8 only.

@bytefish bytefish requested a review from jonfreedman October 9, 2020 07:57
@jonfreedman
Copy link
Copy Markdown
Contributor

Note we're still actually building in github actions using JDK 11

@bytefish
Copy link
Copy Markdown
Owner Author

bytefish commented Oct 9, 2020

While I know using ErrorProne and NullAway catches some errors, it leads to build errors, like this:

Error:java: java.lang.RuntimeException: java.lang.NoSuchMethodError: com.sun.tools.javac.util.JavacMessages.add(Lcom/sun/tools/javac/util/JavacMessages$ResourceBundleHelper;)V
Error:java: Caused by: java.lang.NoSuchMethodError: com.sun.tools.javac.util.JavacMessages.add(Lcom/sun/tools/javac/util/JavacMessages$ResourceBundleHelper;)V
Error:java: at com.google.errorprone.BaseErrorProneJavaCompiler.setupMessageBundle(BaseErrorProneJavaCompiler.java:202)
Error:java: at com.google.errorprone.ErrorProneJavacPlugin.init(ErrorProneJavacPlugin.java:40)

I know there are special ways to set it up for Java 1.8:

We can activate it lateron again, for now I would like to have the build compiled again.

@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit 20b695a and detected 34 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 8
Duplication 26

View more on Code Climate.

@bytefish bytefish merged commit 940ac75 into master Oct 9, 2020
@bytefish bytefish deleted the jdk18 branch September 3, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants