Conversation
jonfreedman
approved these changes
Oct 9, 2020
Contributor
|
Note we're still actually building in github actions using JDK 11 |
Owner
Author
|
While I know using ErrorProne and NullAway catches some errors, it leads to build errors, like this: I know there are special ways to set it up for Java 1.8: We can activate it lateron again, for now I would like to have the build compiled again. |
|
Code Climate has analyzed commit 20b695a and detected 34 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have merged all modules into a single jar, so we don't build multiple-modules anymore. In Issue #103 it became clear, that targetting multiple JDKs using a
classifieris apparently not possible. The project doesn't use any specific Java11 Features, so we should be safe to build for 1.8 only.