Skip to content

Improve ByteArrayValueHandler. #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bytefish merged 1 commit into from
Nov 29, 2018
Merged

Improve ByteArrayValueHandler. #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions PgBulkInsert/src/main/java/de/bytefish/pgbulkinsert/PgBulkInsert.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
import de.bytefish.pgbulkinsert.mapping.AbstractMapping;
import de.bytefish.pgbulkinsert.pgsql.PgBinaryWriter;
import org.postgresql.PGConnection;
import org.postgresql.copy.CopyIn;
import org.postgresql.copy.CopyManager;
import org.postgresql.copy.PGCopyOutputStream;

import java.sql.SQLException;
Expand Down Expand Up @@ -45,13 +43,10 @@ public PgBulkInsert(IConfiguration configuration, AbstractMapping<TEntity> mappi
*/
public void saveAll(PGConnection connection, Stream<TEntity> entities) throws SQLException {

CopyManager cpManager = connection.getCopyAPI();
CopyIn copyIn = cpManager.copyIn(mapping.getCopyCommand());

try (PgBinaryWriter bw = new PgBinaryWriter(configuration.getBufferSize())) {

// Wrap the CopyOutputStream in our own Writer:
bw.open(new PGCopyOutputStream(copyIn, 1));
bw.open(new PGCopyOutputStream(connection, mapping.getCopyCommand(), 1));

// Insert Each Column:
entities.forEach(entity -> saveEntitySynchonized(bw, entity));
Expand All @@ -67,13 +62,10 @@ public void saveAll(PGConnection connection, Stream<TEntity> entities) throws SQ
*/
public void saveAll(PGConnection connection, Collection<TEntity> entities) throws SQLException {

CopyManager cpManager = connection.getCopyAPI();
CopyIn copyIn = cpManager.copyIn(mapping.getCopyCommand());

try (PgBinaryWriter bw = new PgBinaryWriter(configuration.getBufferSize())) {

// Wrap the CopyOutputStream in our own Writer:
bw.open(new PGCopyOutputStream(copyIn, 1));
bw.open(new PGCopyOutputStream(connection, mapping.getCopyCommand(), 1));

// Insert Each Column:
entities.forEach(entity -> saveEntity(bw, entity));
Expand Down
12 changes: 5 additions & 7 deletions ...lkInsert/src/main/java/de/bytefish/pgbulkinsert/pgsql/handlers/ByteArrayValueHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,9 @@

public class ByteArrayValueHandler extends BaseValueHandler<byte[]> {

@Override
protected void internalHandle(DataOutputStream buffer, final byte[] value) throws Exception {
buffer.writeInt(value.length);
for(byte b : value) {
buffer.writeByte(b);
}
}
@Override
protected void internalHandle(DataOutputStream buffer, final byte[] value) throws Exception {
buffer.writeInt(value.length);
buffer.write(value, 0, value.length);
}
}