Errorprone#80
Merged
jonfreedman merged 15 commits intomasterfrom May 20, 2020
Merged
Conversation
- add checker-qual compile scoped dependency to provide @nullable annotation - fix some trivial errors/warnings to observe behaviour in github actions
# Conflicts: # PgBulkInsert/pom.xml
- PgBinaryWriter#open removed, now opened in constructor - SimpleRowWriter#open removed, now opened in constructor - PostgreSqlUtils#tryGetPGConnection now returns Optional<PGConnection> and OutParameter removed
- move compiler/jar plugin definition into pluginManagement so parent pom doesn't compile an empty jar - remove compile-jdk11 execution and just set default execution to jdk11 - don't inherit enforcer plugin - fix errorprone/nullaway issues in tests now compiler correctly setup
There is not a lot we can do about the ReflectionUtils library used in the project. I have opted to supress the casts, so we don't end up with unfixable warnings.
There is no right or wrong in this case.
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 84a8f36 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 88.4% (50% is the threshold). This pull request will bring the total coverage in the repository to 67.3% (-0.4% change). View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.