Conversation
Collaborator
say25
commented
Oct 2, 2019
say25
commented
- Takes advantage of await using from C#8
- Proves that we are still compatible with Npgsql 4.1.1
- In Various changes to reestablish 4.0 backwards compat npgsql/npgsql#2658 @roji simply removed the return type for NpgsqlBinaryImporter.Complete but not the return type for the async version of Complete. As we call the async version of Complete for both synchronous and asynchronous calls behind the scenes using "Async Magic"™️ our library still works with this return type removed
say25
commented
Oct 2, 2019
Owner
|
@say25 Looks good to me! All changes look good to me and I accepted them, but the GitHub UI doesn't seem to like it. Could you please merge it, because I am quite busy at the moment. |
Collaborator
Author
|
@bytefish No problem 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.