Replaced magic numbers with named constants#62
Merged
byteshiftlabs merged 4 commits intomainfrom Feb 8, 2026
Merged
Conversation
- Created centralized constants.h with 200+ semantic constants - Fixed errno handling: converted set_errno/return-1 to RETURN_ERRNO - Replaced hardcoded values: sector size, timer freq, paths, colors, MMIO addresses - Fixed 6 allocation failures in ext2_write.c - Removed duplicate code in trap.c - Build: 0 errors, 0 warnings
byteshiftlabs
added a commit
that referenced
this pull request
Feb 26, 2026
## Changes - Created centralized constants.h with 200+ semantic constants - Fixed errno handling: converted set_errno/return-1 to RETURN_ERRNO - Replaced hardcoded values: sector size, timer freq, paths, colors, MMIO addresses - Fixed 6 allocation failures in ext2_write.c - Removed duplicate code in trap.c ## Testing - Build: 0 errors, 0 warnings - QEMU boot test: PASSES
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testing