Skip to content

Sock Drawer #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
byteskeptical merged 56 commits into from
Oct 14, 2025
Merged

Sock Drawer #68

byteskeptical merged 56 commits into from
Oct 14, 2025

Conversation

@byteskeptical
Copy link
Owner

@byteskeptical byteskeptical commented Aug 16, 2025

Don't leave socks lying around.

@byteskeptical byteskeptical self-assigned this Aug 16, 2025
@byteskeptical byteskeptical linked an issue Aug 16, 2025 that may be closed by this pull request
Version 1.1.9 seems to keep open TCP connections after connection.close() #67
Closed
@byteskeptical
adding python 3.13 to the test suite and as the default to the publis…
c73db27 
…h and document workflows. version bump
@byteskeptical
addition of python 3.13 requires another call to drivedrop to avoid n…
c6093c5 
…ew behavior that returns two leading // for certain normalized windows paths
@byteskeptical
unfortunately this is a deeper issue that requires upstream parity. W…
8c24763 
…orkaround in place as unsure when and how paramiko will handle this.
@byteskeptical
and there's a trailing backslash now as well, 3.13 support off to a r…
8e41a59 
…ough start
@byteskeptical
tests caught something yay!
4c382b5
@byteskeptical
is this a bug?
236f478
@byteskeptical
resetting to root on channel reuse
fa5cfa0
@byteskeptical
bring the test to parity with similar cd ones, just use channel name …
08f02b8 
…instead of relying on get_ident
@byteskeptical
coming into focus
bd5776c
@byteskeptical
lets do both
b3daf93
@byteskeptical
now what is going on with Windows python3.13
a641b3e
@byteskeptical
this could be the cause of my windows python 3.13 issues
61b2a84
@byteskeptical
keepin it posix for test asserts, definitely need the chdir reset in …
5b52585 
…_sftp_channel for cached channels
@byteskeptical
I suspect this is all attributable to the stricter absolute path defi…
fff996f 
…nition in 3.13 clashing with posix paths
@byteskeptical
need both apparently
023a26d
@byteskeptical
absolutely sus
1156977
@byteskeptical
unfortunate complexity
44bbc3c
@byteskeptical
taking care of the none case for the root
6a4d3a9
@byteskeptical
additional logging
0294913
@byteskeptical
upstream issue is spreading in 3.13
42dd827
@byteskeptical
need another test
da686fd
@byteskeptical
refactor reached
47e5949
@byteskeptical
normalize not feeling so normal
d0eb86f
@byteskeptical
moving timeout setter ordering in channel creation as well as channel…
e6b0904 
… cwd reset.
@byteskeptical
final attempt for the night
9108b4b
@byteskeptical
this is the last one
37efb3b
@byteskeptical
I will go to sleep after this
bcf2ffe
@byteskeptical
adding _default_path to both scenarios
84d9856
@byteskeptical
setting a default cwd cache wise, then setting each threads version a…
b0ca43c 
…s well
@byteskeptical
what I get for language hopping
6af2294
@byteskeptical
refactored channel cache and default_path usage
c63ed88
@byteskeptical
the blight of windows 3.13 continues
98daf0f
@byteskeptical
debug log for failing tests
accb70c
@byteskeptical
another one
ddf0c99
@byteskeptical
where does it have to be set?
d56982a
@byteskeptical
pwd is returning something other than on 3.13, this is the fix, hopef…
7736a9c 
…ully
@byteskeptical
moving .closed check out of the finally block
62ab69c
@byteskeptical
additional path logic included in cd to try and handle the 3.13 windo…
ac6f432 
…ws edge case
@byteskeptical
turns out you have to import functions in python
4b1c5d8
@byteskeptical
stop iteration pass in a singular try catch not panning out
622cf38
@byteskeptical
only setting default_path on new connections otherwise using self._ca…
e7f7908 
…che.cwd
@byteskeptical
lint trapped
501ee27
@byteskeptical
looking good feeling better
d048bd4
@byteskeptical
need to set the _cache default for cwd field in the Connection init i…
3c0d9ba 
…nstead of _sftp_channel
@byteskeptical
only using setdefault once
422d02b
@byteskeptical
setdefault at Connection init not enough to set for reused threads
16ab107
@byteskeptical
using cache.cwd in get tree operations
75c3da6
@byteskeptical
making sure the _cache.cwd attribute is in scope for get_r
f665b8f
@byteskeptical
fix the pwd expectation in get_r tests now that we utilize _cache.cwd
493a07e
@byteskeptical
updating release date, and removing unused variable
882cf5d
@byteskeptical byteskeptical linked an issue Oct 14, 2025 that may be closed by this pull request
_channel.close() AttributeError: 'NoneType' object has no attribute 'close' #70
Closed
@byteskeptical
Copy link
Owner Author

byteskeptical commented Oct 14, 2025

Need to follow-up on upstream changes in windows behavior for versions > 3.13

@byteskeptical byteskeptical merged commit a6d8e98 into root Oct 14, 2025
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@byteskeptical byteskeptical

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

_channel.close() AttributeError: 'NoneType' object has no attribute 'close' Version 1.1.9 seems to keep open TCP connections after connection.close()

1 participant

@byteskeptical