Skip to content

Conversation

@gregreich
Copy link
Contributor

Let's do this as a pull request, so you also get the tests.

Signed-off-by: Gregor Reich <gregor.reich@uzh.ch>
@coveralls
Copy link

coveralls commented May 12, 2017

Coverage Status

Coverage decreased (-0.2%) to 99.613% when pulling 169b404 on gregreich:children_setter into 1c8e087 on c0fec0de:master.

@gregreich
Copy link
Contributor Author

The build fails for python 2.6, because I use assertRaises as a context manager (which is handy if you test assignments with assertRaises), which has only been added in 2.7:

"Changed in version 2.7: Added the ability to use assertRaises() as a context manager." (from Python unittest doc)

Can you accept this build failure?

@c0fec0de
Copy link
Owner

Please see https://github.com/c0fec0de/anytree/blob/master/tests/helper.py
I implemented my own assert_raises because of that...

python 2.6 compatibility

Signed-off-by: Gregor Reich <gregor.reich@uzh.ch>
@coveralls
Copy link

coveralls commented May 15, 2017

Coverage Status

Coverage decreased (-0.2%) to 99.613% when pulling e661468 on gregreich:children_setter into 1c8e087 on c0fec0de:master.

Signed-off-by: Gregor Reich <gregor.reich@uzh.ch>
@coveralls
Copy link

coveralls commented May 15, 2017

Coverage Status

Coverage increased (+0.01%) to 99.806% when pulling a652d6e on gregreich:children_setter into 1c8e087 on c0fec0de:master.

Signed-off-by: Gregor Reich <gregor.reich@uzh.ch>
@coveralls
Copy link

coveralls commented May 17, 2017

Coverage Status

Coverage increased (+0.01%) to 99.806% when pulling d4b54a5 on gregreich:children_setter into 1c8e087 on c0fec0de:master.

@c0fec0de c0fec0de merged commit 70f8666 into c0fec0de:master May 23, 2017
@gregreich gregreich deleted the children_setter branch September 16, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants