Update dotexporter to work on Windows/Cygwin #46
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, the current "to_picture" function does not work as the temporary file name is not visible to the system. Therefore, calling "dot" on the command line will result in a FileNotFoundError. The fix changes the function so that on windows/cygwin, the file is not deleted until after the picture is made. Once the picture is made, the file in unlinked.
Update Dotexporter.to_picture to work on Windows/Cygwin
Author
|
Code for issue #47 |
Owner
|
Thanks for the pull request. |
c0fec0de
added a commit
that referenced
this pull request
Jun 24, 2018
c0fec0de
added a commit
that referenced
this pull request
Jun 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the current "to_picture" function does not work as the temporary file name is not visible to the system. Therefore, calling "dot" on the command line will result in a FileNotFoundError.
The fix changes the function so that on windows/cygwin, the file is not deleted until after the picture is made. Once the picture is made, the file in unlinked.
I think I may have accidentally made one too many commits - my bad, new to github :).