Skip to content

Simplify the service worker's onfetch handler#45

Merged
rthellend merged 2 commits intomainfrom
simplify-onfetch
Oct 13, 2025
Merged

Simplify the service worker's onfetch handler#45
rthellend merged 2 commits intomainfrom
simplify-onfetch

Conversation

@rthellend
Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @rthellend, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request simplifies the asynchronous logic within the service worker's onfetch and onmessage handlers. By refactoring the promise-based flow, the code becomes more straightforward, directly assigning response resolution functions to appStreams entries, which are then immediately callable upon receiving messages. This change improves readability and maintains the same functionality with a cleaner implementation.

Highlights

  • Simplified onfetch Handler: The service worker's onfetch event handler has been refactored to use a more direct and less nested Promise structure for responding to fetch requests, improving clarity and maintainability.
  • Direct Function Assignment for appStreams: The appStreams[id] entry is now directly assigned a function that resolves the fetch response, rather than a Promise that resolves to a function, streamlining the asynchronous flow.
  • Streamlined Message Handling: The self.onmessage handler has been updated to directly invoke the function stored in appStreams[id], aligning with the new pattern of direct function assignment.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the onfetch handler in the service worker by removing nested promises. The change is a good improvement for readability. I've added one suggestion to further improve the onfetch handler by using async/await and adding a timeout to prevent potential memory leaks if the client page becomes unresponsive.

Comment thread docroot/stream-helper.js
@rthellend rthellend merged commit 35bd20d into main Oct 13, 2025
1 check passed
@rthellend rthellend deleted the simplify-onfetch branch October 13, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant