Allow @ in username

[rthellend]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @rthellend, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the SSH client's ability to parse user and host information, specifically addressing a limitation where usernames containing the '@' symbol were incorrectly handled. By implementing a new parsing strategy that identifies the last '@' as the delimiter between username and hostname, the change ensures that complex usernames are correctly interpreted, improving the robustness and flexibility of SSH connections.

Highlights

• New Utility Function: A new helper function, parseUserHost, has been introduced to accurately separate a target string into a username and hostname by splitting on the last occurrence of the '@' symbol.
• Improved Username Parsing: The sshClient function now utilizes the parseUserHost utility, allowing usernames to contain '@' characters without being misinterpreted as part of the hostname.
• Consistent Jump Host Parsing: The same parseUserHost logic has been applied to the parsing of jump host entries, ensuring uniform and correct handling of usernames within jump host specifications.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request modifies the SSH client logic to allow '@' characters in usernames by splitting the user@host string at the last '@' instead of the first. This is achieved by introducing a new parseUserHost function. The change is logical and correctly applied for both the main target and jump hosts. I have one suggestion to improve maintainability by adding a doc comment to the new function.