Merged
Conversation
poquirion
reviewed
Jun 15, 2023
Comment on lines
+337
to
+340
| metric_name = <NAME>,[NAME],[] | ||
| readset_name = <NAME>,[NAME],[] | ||
| sample_name = <NAME>,[NAME],[] | ||
| patient_name = <NAME>,[NAME],[] |
Contributor
There was a problem hiding this comment.
Should be:
metric_name = <NAME> [,<NAME>] [...]
poquirion
reviewed
Jun 15, 2023
| post_input = post_data.split('=') | ||
| if post_input[0] in ["metric_name", "readset_name", "sample_name", "patient_name"]: | ||
| model_class = post_input[0].split('_')[0] | ||
| names = post_input[1].split(',') |
Contributor
There was a problem hiding this comment.
ca va prende du nétoyage pour les espaces aussi je pense.
Contributor
Author
There was a problem hiding this comment.
Tu veux que je mette une regex dès maintenant? Dans unroll il n'a pas de regex pour les IDs non plus; ça en prendrait aussi?
Contributor
There was a problem hiding this comment.
Je suis un peut moins inquet pour unroll.
On a une définition stricte de la tête que doivent avoir ["metric_name", "readset_name", "sample_name", "patient_name"] qu'on peut mettre dans un regex?
Contributor
Author
There was a problem hiding this comment.
Pas vraiment...
poquirion
reviewed
Jun 15, 2023
Contributor
poquirion
left a comment
poquirion
left a comment
There was a problem hiding this comment.
Only minor checks are required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.