Call resize handlers only if chart is displayed#2164
Merged
kt3k merged 1 commit intoc3js:masterfrom Sep 15, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2164 +/- ##
=========================================
- Coverage 73.98% 73.88% -0.1%
=========================================
Files 51 51
Lines 4178 4185 +7
=========================================
+ Hits 3091 3092 +1
- Misses 1087 1093 +6
Continue to review full report at Codecov.
|
Member
|
Thanks for the contribution. This change makes sense to me.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current implementation the resize handlers are called even if the chart is not displayed. This is not ideal when having one chart in focus and some hidden ones, as all event handlers get called and performance degrades. Also, while
Chromebehaves correctly and does not actually change the width of the hidden ones,Firefoxtries to resize the hidden elements and sets incorrect full widths, visible after the hidden charts are re-displayed. By checking theoffsetParentwe can tell if the chart is displayed or not and we can skip resize handling if hidden.@kt3k