Skip to content

Migrate to CircleCI 2.0#2170

Merged
kt3k merged 5 commits intoc3js:masterfrom
serima:feature/circleci-20
Sep 15, 2017
Merged

Migrate to CircleCI 2.0#2170
kt3k merged 5 commits intoc3js:masterfrom
serima:feature/circleci-20

Conversation

@serima
Copy link
Copy Markdown
Contributor

@serima serima commented Sep 13, 2017

Summary

Test

Only one test has failed.
Is there anyone who knows something about this problem?

I tried passing the --no-sandbox flag to chrome in karma.conf.js, but the result was the same.
like this:

    browsers: ['ChromeNoSandbox'],
    // ...
    customLaunchers: {
      ChromeNoSandbox: {
        base: 'Chrome',
        flags: ['--no-sandbox']
      }
    },
Chrome 61.0.3163 (Linux 0.0.0): Executed 297 of 297 (1 FAILED) (47.826 secs / 47.487 secs)
TOTAL: 1 FAILED, 296 SUCCESS


1) should split tick text properly
     c3 chart axis axis.x.tick.width category axis not rotated
     Expected 'tick text on' to be 'tick text on category'.
    at SVGTSpanElement.<anonymous> (/tmp/spec/axis-spec.js:417:45 <- /tmp/fb3886d1049e972d58c80727300a4e30.browserify:11406:46)
    at /tmp/node_modules/d3/d3.js:962:0 <- /tmp/fb3886d1049e972d58c80727300a4e30.browserify:963:16
    at d3_selection_each (/tmp/node_modules/d3/d3.js:968:0 <- /tmp/fb3886d1049e972d58c80727300a4e30.browserify:969:30)
    at Array.d3_selectionPrototype.each (/tmp/node_modules/d3/d3.js:961:0 <- /tmp/fb3886d1049e972d58c80727300a4e30.browserify:962:12)
     Expected 'category axis' to be 'axis'.
    at SVGTSpanElement.<anonymous> (/tmp/spec/axis-spec.js:417:45 <- /tmp/fb3886d1049e972d58c80727300a4e30.browserify:11406:46)
    at /tmp/node_modules/d3/d3.js:962:0 <- /tmp/fb3886d1049e972d58c80727300a4e30.browserify:963:16
    at d3_selection_each (/tmp/node_modules/d3/d3.js:968:0 <- /tmp/fb3886d1049e972d58c80727300a4e30.browserify:969:30)
    at Array.d3_selectionPrototype.each (/tmp/node_modules/d3/d3.js:961:0 <- /tmp/fb3886d1049e972d58c80727300a4e30.browserify:962:12)

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 15, 2017

Codecov Report

Merging #2170 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2170     +/-   ##
=========================================
- Coverage   73.98%   73.88%   -0.1%     
=========================================
  Files          51       51             
  Lines        4178     4185      +7     
=========================================
+ Hits         3091     3092      +1     
- Misses       1087     1093      +6
Impacted Files Coverage Δ
src/core.js 89.19% <0%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69f975c...fa9c068. Read the comment docs.

@kt3k
Copy link
Copy Markdown
Member

kt3k commented Sep 15, 2017

Thanks for the contribution!

I like the idea to migrate to circle ci 2.0. Thanks for creating the configuration!

The only problem here is the test case above. That test case depends on the font of the environment and should be fixed somehow systematically. We are going to fix the test case later. So please skip it for now.

like:

xit('should split tick text properly', function () {

@serima serima changed the title [Question] Migrate to CircleCI 2.0 Migrate to CircleCI 2.0 Sep 15, 2017
@serima
Copy link
Copy Markdown
Contributor Author

serima commented Sep 15, 2017

Hi @kt3k, thank you. skipped a test!

@kt3k
Copy link
Copy Markdown
Member

kt3k commented Sep 15, 2017

@serima
Thanks! Merging.

@kt3k kt3k merged commit 96bebfa into c3js:master Sep 15, 2017
@serima serima deleted the feature/circleci-20 branch September 15, 2017 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants