Migrate to CircleCI 2.0#2170
Merged
kt3k merged 5 commits intoc3js:masterfrom Sep 15, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2170 +/- ##
=========================================
- Coverage 73.98% 73.88% -0.1%
=========================================
Files 51 51
Lines 4178 4185 +7
=========================================
+ Hits 3091 3092 +1
- Misses 1087 1093 +6
Continue to review full report at Codecov.
|
Member
|
Thanks for the contribution! I like the idea to migrate to circle ci 2.0. Thanks for creating the configuration! The only problem here is the test case above. That test case depends on the font of the environment and should be fixed somehow systematically. We are going to fix the test case later. So please skip it for now. like: xit('should split tick text properly', function () { |
Contributor
Author
|
Hi @kt3k, thank you. skipped a test! |
Member
|
@serima |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test
Only one test has failed.
Is there anyone who knows something about this problem?
I tried passing the
--no-sandboxflag to chrome in karma.conf.js, but the result was the same.like this: