Conversation
Codecov Report
@@ Coverage Diff @@
## master #2260 +/- ##
=======================================
Coverage 73.88% 73.88%
=======================================
Files 51 51
Lines 4185 4185
=======================================
Hits 3092 3092
Misses 1093 1093Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have configured circle ci and it seems working well for months. I think now it's safe to switch to circle ci.
In travis, recently chrome module stopped working because of permission error of chrome's sandbox helper. See the build. The error doesn't seem caused by our error, but the problem of travis. This error stops our workflow and I guess it requires lots of work to figure out correct workaround for it. So I think it's good timing to switch to circle.