Major memory leak fix#2272
Closed
Conversation
aendra-rininsland
requested changes
Jan 29, 2018
Member
aendra-rininsland
left a comment
aendra-rininsland
left a comment
There was a problem hiding this comment.
@nazihahmed Thank you so much looking into this, it's been an issue that's plagued C3 for ages. That said, the changes to package.json need to be reverted or otherwise deployment will be broken.
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "c3", | |||
| "name": "alooma-c3", | |||
Member
There was a problem hiding this comment.
This will break everything if merged into master.
Contributor
Author
There was a problem hiding this comment.
i know i did this to publish to npm, i will change into a specific branch for merging for you
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the detach event listener was not detached properly after calling .destroy
so I basically added resizeIfElementDisplayed to $$ (this), and detach the event listener properly
also .remove must be called on $$.resizeFunction on destroy,
anyways this fixed all my memory issue,
Fix #926