Merged
Conversation
panthony
force-pushed
the
feat/pad_angle
branch
from
15ce4ad to
bfbb804
Compare
panthony
force-pushed
the
feat/pad_angle
branch
from
bfbb804 to
de78680
Compare
Codecov Report
@@ Coverage Diff @@
## master #2669 +/- ##
==========================================
+ Coverage 80.13% 80.29% +0.16%
==========================================
Files 57 59 +2
Lines 4520 4538 +18
==========================================
+ Hits 3622 3644 +22
+ Misses 898 894 -4
Continue to review full report at Codecov.
|
beninsocrata
pushed a commit
to socrata/c3
that referenced
this pull request
Oct 31, 2019
* add pie.padAngle and donut.padAngle options * add API to get/set padAngle for both pie and donut * add pie.padAngle and donut.padAngle in reference doc * add padAngle option in donut sample * bind getPadAngle method to self * use chart main instead of global D3 to select chart's elements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds:
padAngleoption for both pie & donutpadAngleIt supersede #1921 and closes #1920
I was not quite sure how to expose the API, should we duplicate under both donut & pie key? Something else?