Readdition of axisY and axisY2 inner options#742
Merged
Conversation
added 4 commits
November 20, 2014 15:22
Update to enable the axisY inside option
This commit readd back the axisY option
Contributor
Author
|
According to #640 I'm not the only one that need this feauture back. So please consider adding this back again. Thanks |
Member
|
Thanks for this PR. I fixed a little and merged. I'll release in the next version v0.4.4. |
Member
There was a problem hiding this comment.
Yes. I fixed this by another commit.
There was a problem hiding this comment.
But it isn't on master branch, is it? https://github.com/masayuki0812/c3/blob/master/src/core.js#L112
There was a problem hiding this comment.
But that commit doesn't fix config.axis_y2_inner, does it? Notice the y2.
Member
There was a problem hiding this comment.
Oh.. I see. You're right. I'll fix this. Thanks!
masayuki0812
added a commit
that referenced
this pull request
Dec 6, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added back the axisY and axisY2 inner options